Implement a Svelte StoryIndexer #69
Conversation
Socket Security ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 New install scripts detectedA dependency change in this PR is introducing new install scripts to your install step.
😵💫 Bin script confusionThis package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack.
Socket.dev scan summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
|
@j3rem1e what's the best way for us to test this out? Would you be willing to release it in an alpha version, so that we can experiment with it with recent 7.0 alphas and with the svelte-vite framework? |
|
It has been published with version "2.0.8--canary.8172dc5.0". We can maybe create a "future" branch, or merge it on the current branch (it should work if I remove TS definition, which doesn't exists on main) |
|
cool, I'll try out the canary, I didn't see that, thanks. |
|
Is there any progress on that ? It seems to work , but now there is newer canaries versions of 2.0.9 that can't be really tested without this indexer fix |
|
🚀 PR was released in |
|
You have merged an upgrade to v7.0.0-alpha in a minor version ? |
|
It looks like this was not tagged correctly before it was merged. @JReinhold maybe you could move this to a |
|
sorry, this was a complete blunder from me. you are both right. I'll try to fix it. |
|
Thanks for the catch, @j3rem1e, and thanks for the fixup, @JReinhold! |
Upgrade to Storybook v7 (alpha) and webpack5
Implement a new StoryIndexer in order to use the new "stories.json" format.
Fix #65
Two bugs, but I am not sure it come from this implementation :
📦 Published PR as canary version:
2.0.9--canary.69.9b95d2b.0✨ Test out this PR locally via:
npm install @storybook/addon-svelte-csf@2.0.9--canary.69.9b95d2b.0 # or yarn add @storybook/addon-svelte-csf@2.0.9--canary.69.9b95d2b.0